Make sure all network interfaces are routable #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for rancher-sandbox#6051 It makes sure the boot-time /etc/network/interfaces file is copied to the persisted location and then restarts the networking service yet one more time. This workaround should be removed when the issue is fixed upstream. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
network-interfaces
branch
from
a26f343 to
678f0c8
Compare
mook-as
approved these changes
Nov 27, 2023
No, we don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #6051
It makes sure the boot-time /etc/network/interfaces file is copied to the persisted location and then restarts the networking service yet one more time.
This PR is intended for the 1.11.1 patch release, so should be as minimal as possible.
The workaround should be removed when the issue is fixed upstream (likely in the bump to Lima 0.19.0).
The functionality can be tested with the CI build with:
rdctl shell ip rThe output should include
defaultroutes foreth0,rd0, andrd1. With the 1.11.0 release the output only includes the default route foreth0.As an additional test you can also run (on the host)
curl http://$ITFforrd0andrd1and make sure you get the404 page not founderror from Traefik. With 1.11.0 the command will timeout.