Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failing on API diff validation #359

Closed
salasberryfin opened this issue Jan 17, 2024 · 1 comment
Closed

CI failing on API diff validation #359

salasberryfin opened this issue Jan 17, 2024 · 1 comment
Assignees
@salasberryfin
Labels
kind/chore Internal stuff

Comments

@salasberryfin
Copy link
Contributor

salasberryfin commented Jan 17, 2024 •
edited
Loading

Description

For the last couple of days we've had API diff validation workflow failing on new PRs.

After some investigation, it looks like this matches joelanford/go-apidiff's new release. As we're using the latest version here, CI is failing because our workflow is configured to use Go 1.18 while this new API diff action requires >1.19.

Updating the workflow's Go version to match the project's (Go 1.20) should fix this issue.
@salasberryfin salasberryfin added the kind/chore Internal stuff label Jan 17, 2024
@salasberryfin salasberryfin self-assigned this Jan 17, 2024
@salasberryfin salasberryfin moved this to Backlog in CAPI / Turtles Jan 17, 2024
@salasberryfin salasberryfin moved this from Backlog to In Progress (5 max) in CAPI / Turtles Jan 17, 2024
@salasberryfin salasberryfin mentioned this issue Jan 17, 2024
Merged
5 tasks
@salasberryfin salasberryfin moved this from In Progress (5 max) to PR to be reviewed in CAPI / Turtles Jan 17, 2024
@salasberryfin salasberryfin moved this from PR to be reviewed to Done in CAPI / Turtles Jan 17, 2024
@mjura
Copy link
Contributor

mjura commented May 27, 2024

It will be suppressed by rancher/highlander#89

@mjura mjura closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salasberryfin salasberryfin

Labels
kind/chore Internal stuff
Projects
CAPI / Turtles
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjura @salasberryfin