-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate unapproved GHA used in workflows #89
Comments
In order to create PRs we can use either the
vs
Thoughts / preferences @alexander-demicev ? My preference would be for the latter (script) unless we want to invoke it via a Makefile target instead. |
@yiannistri Yes, we can use the script action |
This was referenced May 20, 2024
5 tasks
This was referenced May 23, 2024
From the turtles side there is also needed: rancher/turtles-docs#94 |
This was referenced May 28, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Soon only approved GHA will be allowed to be used in our workflows. We have some GHAs which are not approved and don't fit the criteria to be approved:
EKS/AKS/GKE Operators:
https://github.com/rancher/aks-operator/blob/archive/.github/workflows/apidiff.yaml#L14
https://github.com/rancher/aks-operator/blob/archive/.github/workflows/e2e.yaml#L75
https://github.com/rancher-sandbox/highlander-reusable-workflows/blob/main/.github/workflows/update-rancher-charts.yaml#L71
GKE
https://github.com/rancher/gke-operator/blob/main/.github/workflows/update-rancher-charts.yaml#L59
Turtles
https://github.com/rancher/turtles/blob/main/.github/workflows/dependabot.yml#L30
https://github.com/rancher/turtles/blob/main/.github/workflows/nightly-test-release.yaml#L120
https://github.com/rancher/turtles/blob/main/.github/workflows/nightly-test-release.yaml#L158
https://github.com/rancher/turtles/blob/main/.github/workflows/pr-md-link-check.yaml#L18
https://github.com/rancher/turtles/blob/main/.github/workflows/pr_size_labeler.yml#L12
https://github.com/rancher/turtles/blob/main/.github/workflows/pr_type.yaml#L12
https://github.com/rancher/turtles/blob/main/.github/workflows/test_chart.yaml#L59
We need to deprecate these by replacing them with bash scripts or creating an alternative in https://github.com/rancher-sandbox/highlander-reusable-workflows/
The text was updated successfully, but these errors were encountered: