Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wildcards in EncryptionConfiguration #599

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Support wildcards in EncryptionConfiguration #599

merged 6 commits into from
Oct 17, 2024

Conversation

jbiers
Copy link
Member

@jbiers jbiers commented Oct 15, 2024

Issue: #591

@jbiers jbiers requested a review from a team as a code owner October 15, 2024 18:18
mallardduck
mallardduck approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mallardduck mallardduck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we'll add unit tests in a follow up, after those are created lets also add a more complete e2e style test too.

@mallardduck mallardduck added this to the v2.11.0 milestone Oct 17, 2024
@mallardduck
Copy link
Member

Because this targets Rancher 2.11 that means it targets BRO 7.0. Given that head is currently targeting BRO 6.0/Rancher 2.10 - we'll put a freeze on merging this until release/v6.0 is created.

@jbiers jbiers modified the milestones: v2.11.0, v2.10.0 Oct 17, 2024
@jbiers
Copy link
Member Author

jbiers commented Oct 17, 2024

Because this targets Rancher 2.11 that means it targets BRO 7.0. Given that head is currently targeting BRO 6.0/Rancher 2.10 - we'll put a freeze on merging this until release/v6.0 is created.

As mentioned in the main issue, it seems we got QA cycles to get this merged and tested for 2.10 :)

@jbiers jbiers merged commit 1295ee3 into rancher:main Oct 17, 2024
6 checks passed
@mallardduck mallardduck mentioned this pull request Jan 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mallardduck mallardduck mallardduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbiers @mallardduck