[dev-v2.11] rancher-logging 106.0.0-rc.1+up4.10.0 create #4987
+88,823
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
apoorvajagtap
changed the title
apoorvajagtap
force-pushed
the
rancher-48443
branch
from
8b199bd to
d93f0e9
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
apoorvajagtap
changed the title
apoorvajagtap
force-pushed
the
rancher-48443
branch
from
d93f0e9 to
6db6b32
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
mallardduck
requested changes
Jan 23, 2025
jbiers
changed the title
jbiers
reviewed
Jan 23, 2025
| @@ -130,14 +130,14 @@ | |||
| + nodeagent_fluentbit: | |||
| + os: "windows" | |||
| + repository: rancher/fluent-bit | |||
| + tag: 2.2.0 | |||
| + tag: 3.1.8 | |||
There was a problem hiding this comment.
Looks good overall. I see that this PR seems to include changes other than the fluent-bit tag itself, but it's only white spaces as it looks like, perhaps your IDE is doing some formatting?
After fixing what Dan is pointing out it should be good to go 😄
There was a problem hiding this comment.
Hey, Thanks for catching that!
Indeed, it was my IDE. I have disabled the auto-indentation now, so shouldn't bring in unnecessary changes to the patch now.
There was a problem hiding this comment.
Oh yeah a lot better now - way less files. Great work.
There might still be some extra changes we're not expecting but that could be caused by something else. @jbiers looking at the 2.10 PR you did it should only be this tag and the fluentbit_debug one? 🤔
There was a problem hiding this comment.
Ideally the change should only include this tag - here's my commit to the 2.10 PR for reference
apoorvajagtap
force-pushed
the
rancher-48443
branch
from
6db6b32 to
e0bff43
Compare
Validation steps
Ex:-
longhorn-controller:
repository: rancher/hardened-sriov-cni
tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#48443
ForwardPort of #4876
Solution
This PR updates the fluent-bit image for windows to v3.1.8.