-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.9] rancher-logging 104.1.3+up4.8.0 update #5010
base: dev-v2.9
Are you sure you want to change the base?
[dev-v2.9] rancher-logging 104.1.3+up4.8.0 update #5010
Conversation
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
Signed-off-by: Meza <[email protected]>
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Signed-off-by: Meza <[email protected]>
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small note to look into. Overall looks correct other than that. But @jbiers is the definitive authority here as this was originally her changes.
Note: One obvious issue is release.yaml
but that doesn't matter right now. This can't merge until after current release cycle which will change that anyway. So fixing now will just mean needing to fix again later.
@@ -126,7 +126,7 @@ | |||
+ fluentd: | |||
+ repository: rancher/mirrored-kube-logging-fluentd | |||
+ tag: v1.16-4.8-full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this tag apply to this version of logging?
In this case the 2.9 chart is still targeting 4.8.0 of upstream charts. Whereas the 2.10 charts is tracking 4.10.0, so we may want to take care when backporting to avoid any changes there that are specific to 2.10's chart.
Checkpoints for Chart Bumps
release.yaml
:Chart.yaml and index.yaml
:index.yaml
file has an entry for your new chart version.index.yaml
entries for each chart matches theChart.yaml
for each chart.Fill the following only if required by your manager.
Issue: rancher/rancher#46499
Solution
This PR backports the changes from #4907 to dev-2.9 branch.
QA Testing Considerations