Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dapper v0.5.5 breaks rancher/os builds #92

Open
hpdvanwyk opened this issue Jan 27, 2021 · 0 comments · May be fixed by #93
Open

dapper v0.5.5 breaks rancher/os builds #92

hpdvanwyk opened this issue Jan 27, 2021 · 0 comments · May be fixed by #93

Comments

@hpdvanwyk
Copy link

Steps to reproduce:

git clone https://github.com/rancher/os.git rancher-os
cd rancher-os
run make release

Output:

...snip...
+ tag=rancher/os-rootfs:628e6ab0
+ echo 'build-image: Building rancher/os-rootfs:628e6ab0'
build-image: Building rancher/os-rootfs:628e6ab0
+ '[' -x images/00-rootfs/prebuild.sh ']'
+ images/00-rootfs/prebuild.sh
+ dapper -d --build -f images/00-rootfs/Dockerfile -- -t rancher/os-rootfs images/00-rootfs
DEBU[0000] Building os:master using images/00-rootfs/Dockerfile
FATA[0000] pattern contains path separator
+ '[' 1 '!=' 42 ']'
+ exit 1
FATA[0353] exit status 1
make: *** [release-build] Error 1

It look like the following go commit is responsible: golang/go@12cd55c
I assume this was pulled in when updating the go version for v0.5.5.
Pinning the dapper version to v0.5.4 instead of latest in rancher/os allows it to build.
olljanat added a commit to burmilla/os-services that referenced this issue Feb 2, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
dc5fa4c
olljanat added a commit to burmilla/os-kernel that referenced this issue Feb 2, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
76f8f2b
olljanat added a commit to burmilla/os-kernel that referenced this issue Feb 2, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
6a6748a
olljanat added a commit to burmilla/os that referenced this issue Feb 2, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
f963f38
olljanat added a commit to burmilla/os that referenced this issue Feb 2, 2021
@olljanat
Release v1.9.1
76b4a14 
- Bump up kernel to 4.14.218
- Bump up default Docker version to 19.03.15
- Use sysctl value fs.inotify.max_user_instances=1024 instead of 128
- Lock dapper to v0.5.4 because of rancher/dapper#92
olljanat added a commit to burmilla/os-services that referenced this issue Feb 2, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
bca33af
dweomer added a commit to dweomer/rancher-os that referenced this issue Feb 3, 2021
@dweomer
pin dapper to v0.5.4
ee2919c 
Sidestep rancher/dapper#92

Signed-off-by: Jacob Blain Christen <[email protected]>
dweomer added a commit to rancher/os-services that referenced this issue Feb 3, 2021
@dweomer
pin dapper to v0.5.4
09b6634 
Sidestep rancher/dapper#92

Signed-off-by: Jacob Blain Christen <[email protected]>
@h8liu h8liu linked a pull request Feb 4, 2021 that will close this issue
Open
olljanat added a commit to burmilla/os-kernel that referenced this issue Feb 14, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
ec79c56
olljanat added a commit to burmilla/os-services that referenced this issue Apr 8, 2021
@olljanat
Lock dapper to v0.5.4 because of rancher/dapper#92
76b8bab
tredger pushed a commit to tredger/os-services that referenced this issue Jul 24, 2022
@olljanat @tredger
Lock dapper to v0.5.4 because of rancher/dapper#92
0cd9bba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extracts the dir when creating temp files.
1 participant
@hpdvanwyk