Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore vueconfig cleanup with Vue3 migration fixes #11774

Merged

Conversation

cnotv
Copy link
Member

@cnotv cnotv commented Aug 29, 2024

Summary

Fixes #11744

Occurred changes and/or fixed issues

Technical notes summary

There's an issue with the extensions caused by this configuration of the aliases and I'm investigating with #11706

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.10.0 milestone Aug 29, 2024
@cnotv cnotv force-pushed the feature/11744-restore-vue-config-cleanup branch from 565a9a5 to 55b6752 Compare August 29, 2024 17:09
@cnotv cnotv marked this pull request as ready for review August 29, 2024 22:19
@cnotv cnotv force-pushed the feature/11744-restore-vue-config-cleanup branch from 1082537 to 1c24a40 Compare August 30, 2024 20:06
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good and gets us back to the config that we were using in Vue2. Everything that I've tested is looking good for this one. I just have one question about the inclusion of shell/pages/c/_cluster/settings/performance.vue

shell/pages/c/_cluster/settings/performance.vue Outdated Show resolved Hide resolved
rak-phillip
rak-phillip previously approved these changes Aug 31, 2024
@cnotv cnotv force-pushed the feature/11744-restore-vue-config-cleanup branch 2 times, most recently from bd547d2 to 869f325 Compare September 3, 2024 15:47
rak-phillip
rak-phillip previously approved these changes Sep 3, 2024
@cnotv cnotv added the ci/skip-e2e Forcibly skip E2E tests in the CI label Sep 3, 2024
@cnotv cnotv force-pushed the feature/11744-restore-vue-config-cleanup branch from 2017385 to 773dc84 Compare September 4, 2024 15:30
@cnotv cnotv removed the ci/skip-e2e Forcibly skip E2E tests in the CI label Sep 4, 2024
@cnotv cnotv force-pushed the feature/11744-restore-vue-config-cleanup branch from 773dc84 to 82c5680 Compare September 5, 2024 09:02
@cnotv cnotv requested a review from rak-phillip September 5, 2024 15:26
@cnotv cnotv merged commit 3fae34c into rancher:master Sep 5, 2024
30 checks passed
nwmac pushed a commit to nwmac/dashboard that referenced this pull request Oct 24, 2024
* Restore vueconfig cleanup with Vue3 migration fixes

* Fix aliases for vue

* Destructure helper import to avoid duplication

* Fix linting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore vue.config.js cleanup as it breaks on extension
2 participants