-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore vueconfig cleanup with Vue3 migration fixes #11774
Merged
cnotv
merged 4 commits into
rancher:master
from
cnotv:feature/11744-restore-vue-config-cleanup
Sep 5, 2024
Merged
Restore vueconfig cleanup with Vue3 migration fixes #11774
cnotv
merged 4 commits into
rancher:master
from
cnotv:feature/11744-restore-vue-config-cleanup
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
565a9a5
to
55b6752
Compare
1082537
to
1c24a40
Compare
rak-phillip
reviewed
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good and gets us back to the config that we were using in Vue2. Everything that I've tested is looking good for this one. I just have one question about the inclusion of shell/pages/c/_cluster/settings/performance.vue
rak-phillip
previously approved these changes
Aug 31, 2024
bd547d2
to
869f325
Compare
rak-phillip
previously approved these changes
Sep 3, 2024
2017385
to
773dc84
Compare
773dc84
to
82c5680
Compare
rak-phillip
approved these changes
Sep 5, 2024
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* Restore vueconfig cleanup with Vue3 migration fixes * Fix aliases for vue * Destructure helper import to avoid duplication * Fix linting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11744
Occurred changes and/or fixed issues
Technical notes summary
There's an issue with the extensions caused by this configuration of the aliases and I'm investigating with #11706
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist