Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/airgap: allow to use specific version of Rancher #1665

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

ldevulder
Copy link
Contributor

@ldevulder ldevulder commented Dec 11, 2024

This is can be useful to validate specific versions of Rancher Manager in Airgap environment.

Verification run:

@ldevulder ldevulder self-assigned this Dec 11, 2024
@ldevulder ldevulder requested a review from a team as a code owner December 11, 2024 10:45
@ldevulder ldevulder force-pushed the ci-airgap-allow-specific-rancher-version branch 4 times, most recently from 2885153 to b71a396 Compare December 12, 2024 14:47
Copy link
Contributor

@juadk juadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice!

Because at the very early beginning of the alpha release the test will
fail. But we can still manually specify a Rancher version if we know
that the release is good and can be tested.

Signed-off-by: Loic Devulder <[email protected]>
@ldevulder ldevulder force-pushed the ci-airgap-allow-specific-rancher-version branch 4 times, most recently from 4211c15 to 6442aa9 Compare December 16, 2024 12:08
@ldevulder ldevulder force-pushed the ci-airgap-allow-specific-rancher-version branch from 6442aa9 to f51a097 Compare December 16, 2024 13:31
@ldevulder ldevulder merged commit f18a0a3 into main Dec 16, 2024
25 of 26 checks passed
@ldevulder ldevulder deleted the ci-airgap-allow-specific-rancher-version branch December 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants