Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev scripts use same docker network #3205

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Dev scripts use same docker network #3205

merged 1 commit into from
Jan 10, 2025

Conversation

manno
Copy link
Member

@manno manno commented Jan 10, 2025 •
edited
Loading

  • use same docker network for upstream/downstream
  • switch all defaults to "downstream1"
  • dev/setup-rancher-with-dev-fleet idempotency

@manno manno requested a review from a team as a code owner January 10, 2025 15:21
@manno
Dev scripts use same docker network
de40675 
* use same docker network for upstream/downstream
* switch all defaults to "downstream1"
* dev/setup-rancher-with-dev-fleet idempotency
@manno manno changed the title rwip Dev scripts use same docker network Jan 10, 2025
weyfonk
weyfonk approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this 🥇

@manno manno merged commit c27101d into main Jan 10, 2025
12 checks passed
@manno manno deleted the fix-dev-scripts branch January 10, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyfonk weyfonk weyfonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manno @weyfonk