Add cluster config handler unit tests #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjura
force-pushed
the
gke-unit-test
branch
3 times, most recently
from
2c7101c to
13d9c00
Compare
mjura
changed the title
This was referenced Jan 8, 2024
|
Looks like this PR needs a rebase. |
salasberryfin
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Cannot request changes in unchanged lines but looks like this call to the old newClusterCreateRequest may be the cause of the E2E CI failure.
|
I rebased this PR |
salasberryfin
previously approved these changes
Jan 17, 2024
|
It is blocked by rancher/rancher#44206 |
mjura
force-pushed
the
gke-unit-test
branch
3 times, most recently
from
b308edd to
ccb65c0
Compare
mjura
force-pushed
the
gke-unit-test
branch
2 times, most recently
from
69f1ebb to
1075c8f
Compare
mjura
force-pushed
the
gke-unit-test
branch
2 times, most recently
from
1cc2c13 to
021d98f
Compare
mjura
force-pushed
the
gke-unit-test
branch
2 times, most recently
from
84a8004 to
62738c0
Compare
alexander-demicev
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
Issue ##92
Special notes for your reviewer:
This PR will break Rancher integration this is why we have also get merge PR for Rancher rancher/rancher#44253
Checklist: