Automate Qase 222, 210, 261, 209, 217, 195, 230 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parthvi Vala <[email protected]>
valaparthvi
force-pushed
the
automate-aks
branch
from
909328d to
572b194
Compare
cpinjani
reviewed
Sep 25, 2024
| @@ -184,6 +323,37 @@ var _ = Describe("P1Provisioning", func() { | |||
| Expect(err).NotTo(HaveOccurred()) | |||
| }) | |||
|
|
|||
| It("should not be able to edit availability zone of a nodepool", func() { | |||
There was a problem hiding this comment.
Should this be marked XIt ?
Since the current assertion is not the expected result.
There was a problem hiding this comment.
User is not allowed to edit the availability zone, even though POST request does not return an error, the state of AZ is restored. Hence, I did not mark the test as XIt.
There was a problem hiding this comment.
Ok, can we add check to find the AZ are indeed restored.
There was a problem hiding this comment.
It has been added on L#345-354. I could also add UpstreamSpec check if that is what you meant.
cpinjani
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AddNodePoolto include all the fields wrt r/shepherd update.Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Checklist:
Special notes for your reviewer: