Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile libmaxminddb and update lua #63

Merged

Conversation

galal-hussein
Copy link

In v1.0.2 Nginx, it requires version 3.0.5 of ModSecurity and it requires libmaxminddb 1.3+ to work, and centos:8 comes with version 1.2 of libmaxminddb.

The fixes will do the following:

  • Compile libmaxminddb 1.5.2 to work with Modsecurity 3.0.5
  • Updating Lua to 5.3 to be able to compile ModSecurity

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we can drop the whitespace changes to images/nginx/rootfs/Dockerfile

Copy link

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants