Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RKE2 golang test Cache Thrashing #6143

Closed
Tracked by #5678
dereknola opened this issue Jun 6, 2024 · 0 comments
Closed
Tracked by #5678

Fix RKE2 golang test Cache Thrashing #6143

dereknola opened this issue Jun 6, 2024 · 0 comments
Assignees

Comments

@dereknola
Copy link
Member

Is your feature request related to a problem? Please describe.

The unit test and integration test workflows utilized the default caching provided by the setup-go action. However, due to limitations around cache access this is a non optimal use of the cache. Every PR is generating their own cache and throwing out the actually useful cache provide by master branch. You can see this in the current cache.
image

Describe the solution you'd like

What actually needs to happen is:

Master run build-rke2 on merge commits, and build a cache of golang depedencies. Only master branch can SAVE a new cache entry

All PRs/non master branches can only RESTORE cache entries for golang. This prevents an overflow of the 10GB cache with entries that can never be used again.

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant