Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom golang setup action for better caching #6144

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

dereknola
Copy link
Member

Proposed Changes

Use a custom caching strategy for GitHub Action setup-go, which restricts:

  • Only master branch can SAVE caches
  • PRs can only RESTORE (ie read) caches

Types of Changes

GitHub CI

Verification

For now, this PR should not open any new caches

Testing

#6143

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner June 6, 2024 19:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.09%. Comparing base (17cc54f) to head (11739b4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6144   +/-   ##
=======================================
  Coverage   26.09%   26.09%           
=======================================
  Files          32       32           
  Lines        2698     2698           
=======================================
  Hits          704      704           
  Misses       1948     1948           
  Partials       46       46           
Flag Coverage Δ
inttests 9.82% <ø> (ø)
unittests 18.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 1360c6d into rancher:master Jun 6, 2024
6 checks passed
dereknola added a commit to dereknola/rke2 that referenced this pull request Jun 7, 2024
dereknola added a commit to dereknola/rke2 that referenced this pull request Jun 7, 2024
dereknola added a commit to dereknola/rke2 that referenced this pull request Jun 7, 2024
dereknola added a commit that referenced this pull request Jun 10, 2024
* Fix loadManifests function (#6058)

Signed-off-by: Derek Nola <[email protected]>

* Slim down E2E artifacts (#6097)

* Don't use rke2-runtime.tar in e2e

Signed-off-by: Derek Nola <[email protected]>

* Don't upload rke2-runtime.tar

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

* Add custom golang setup action for better caching (#6144)

Signed-off-by: Derek Nola <[email protected]>

* Support MixedOS E2E local testing (#6137)

* Consolidate CreateWindowsCluster test function

Signed-off-by: Derek Nola <[email protected]>

* Support local windows builds in mixedOS e2e test

Signed-off-by: Derek Nola <[email protected]>

* Add mixedos to E2E CI

Signed-off-by: Derek Nola <[email protected]>

* Simplify local cluster provisioning with libvirt native parallel bringup

Signed-off-by: Derek Nola <[email protected]>

* Don't run mixedOS on E2E

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jun 10, 2024
* Fix loadManifests function (#6058)

Signed-off-by: Derek Nola <[email protected]>

* Slim down E2E artifacts (#6097)

* Don't use rke2-runtime.tar in e2e

Signed-off-by: Derek Nola <[email protected]>

* Don't upload rke2-runtime.tar

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

* Add custom golang setup action for better caching (#6144)

Signed-off-by: Derek Nola <[email protected]>

* Support MixedOS E2E local testing (#6137)

* Consolidate CreateWindowsCluster test function

Signed-off-by: Derek Nola <[email protected]>

* Support local windows builds in mixedOS e2e test

Signed-off-by: Derek Nola <[email protected]>

* Add mixedos to E2E CI

Signed-off-by: Derek Nola <[email protected]>

* Simplify local cluster provisioning with libvirt native parallel bringup

Signed-off-by: Derek Nola <[email protected]>

* Don't run mixedOS on E2E

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
dereknola added a commit that referenced this pull request Jun 10, 2024
* Fix loadManifests function (#6058)

Signed-off-by: Derek Nola <[email protected]>

* Slim down E2E artifacts (#6097)

* Don't use rke2-runtime.tar in e2e

Signed-off-by: Derek Nola <[email protected]>

* Don't upload rke2-runtime.tar

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

* Add custom golang setup action for better caching (#6144)

Signed-off-by: Derek Nola <[email protected]>

* Support MixedOS E2E local testing (#6137)

* Consolidate CreateWindowsCluster test function

Signed-off-by: Derek Nola <[email protected]>

* Support local windows builds in mixedOS e2e test

Signed-off-by: Derek Nola <[email protected]>

* Add mixedos to E2E CI

Signed-off-by: Derek Nola <[email protected]>

* Simplify local cluster provisioning with libvirt native parallel bringup

Signed-off-by: Derek Nola <[email protected]>

* Don't run mixedOS on E2E

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>

---------

Signed-off-by: Derek Nola <[email protected]>
@dereknola dereknola deleted the go_cache branch June 13, 2024 16:05
iamsarthakk pushed a commit to iamsarthakk/rke2 that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants