Fix Windows path setting #5698
Merged
Fix Windows path setting #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5698 +/- ##
==========================================
- Coverage 19.18% 18.90% -0.28%
==========================================
Files 25 29 +4
Lines 2262 2623 +361
==========================================
+ Hits 434 496 +62
- Misses 1790 2086 +296
- Partials 38 41 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
brandond
reviewed
Apr 10, 2024
| @@ -100,7 +100,7 @@ func (p *PEBinaryConfig) Bootstrap(ctx context.Context, nodeConfig *config.Node, | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if err := os.Setenv("PATH", execPath+":"+os.Getenv("PATH")); err != nil { | |||
| if err := os.Setenv("PATH", execPath+";"+os.Getenv("PATH")); err != nil { | |||
There was a problem hiding this comment.
FYI there is os.PathListSeparator if you want to avoid forgetting which is which on different platforms.
brandond
approved these changes
Apr 10, 2024
thomasferrandiz
approved these changes
Apr 10, 2024
dereknola
approved these changes
Apr 10, 2024
Signed-off-by: Manuel Buil <[email protected]>
|
Backports tomorrow! |
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
For some reason it was necessary to configure the PATH for RKE2 to work correctly in Windows, as explained in the docs: https://docs.rke2.io/install/quickstart#3-configure-path. The reason is that we were setting the PATH wrongly and using ":" instead of ";". One is typical for Unix systems and the other one is for Windows
Types of Changes
Bugfix
Verification
Run rke2-windows without configuring the PATH previously as set in the docs: https://docs.rke2.io/install/quickstart#3-configure-path
Testing
Linked Issues
#5697
User-Facing Change
Further Comments