Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly tests #7630

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix nightly tests #7630

merged 2 commits into from
Jan 28, 2025

Conversation

dereknola
Copy link
Member

Proposed Changes

  • opensuse leap 15.6+ image no longer has ps installed by default
  • Fixes issue around rke2-killall.sh being in different locations depending on OS.

Types of Changes

Test Fix

Verification

Nightly Install now passes
https://github.com/dereknola/rke2/actions/runs/12894519908

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner January 23, 2025 18:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.74%. Comparing base (649521a) to head (411bfc6).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (649521a) and HEAD (411bfc6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (649521a) HEAD (411bfc6)
unittests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #7630       +/-   ##
==========================================
- Coverage   23.00%   8.74%   -14.26%     
==========================================
  Files          34      34               
  Lines        3500    3500               
==========================================
- Hits          805     306      -499     
- Misses       2647    3171      +524     
+ Partials       48      23       -25     
Flag Coverage Δ
inttests 8.74% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit fa92af2 into rancher:master Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants