-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR: Self managed Rancher cluster #1016
Merged
anmazzotti
merged 3 commits into
rancher:main
from
anmazzotti:adr_self_managed_rancher_cluster
Jan 22, 2025
Merged
ADR: Self managed Rancher cluster #1016
anmazzotti
merged 3 commits into
rancher:main
from
anmazzotti:adr_self_managed_rancher_cluster
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
added
the
status/adr-required
Indicates that the issue or PR contains a decision that needs to be documented in a ADR
label
Jan 20, 2025
Signed-off-by: Andrea Mazzotti <[email protected]>
anmazzotti
force-pushed
the
adr_self_managed_rancher_cluster
branch
from
January 21, 2025 13:06
4016784
to
a20379b
Compare
alexander-demicev
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for writing it up!
salasberryfin
previously approved these changes
Jan 21, 2025
Co-authored-by: Danil Grigorev <[email protected]>
anmazzotti
dismissed stale reviews from salasberryfin and alexander-demicev
via
January 21, 2025 16:30
2b83199
Co-authored-by: Danil Grigorev <[email protected]>
alexander-demicev
approved these changes
Jan 21, 2025
Danil-Grigorev
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/adr-required
Indicates that the issue or PR contains a decision that needs to be documented in a ADR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is an ADR proposal for the Self managed cluster.
Some proof of concept for a simple provisioning script can be found here.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #984
Special notes for your reviewer:
Checklist: