Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when insecure-skip-verify is active #1017

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

anmazzotti
Copy link
Contributor

kind/feature

What this PR does / why we need it:

Just a little notification to explicitly tell the user this setting is enabled.
I'm also open to make this an Error instead for more visibility.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@anmazzotti anmazzotti requested a review from a team as a code owner January 20, 2025 16:46
@anmazzotti anmazzotti self-assigned this Jan 20, 2025
@anmazzotti anmazzotti enabled auto-merge January 21, 2025 10:00
@anmazzotti anmazzotti merged commit 1af5213 into rancher:main Jan 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants