Remove docker build for clusterclass manager #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Mazzotti <[email protected]>
salasberryfin
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Thanks @anmazzotti. I'm a bit confused why I ended up leaving it like this. I agree it's better to remove it and I think it also aligns with what we do with etcdrestore.
yiannistri
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@salasberryfin I noticed the
exp/clusterclass/Dockerfilewas cleaned up, so I think it makes sense to not try to build and use the docker image at this stage.make dev-envshows an error when trying to build the image and may be confusing for users.That said, the clusterclass manager is correctly loaded by tilt, so it's still available in the development environment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: