Use compile time detection of what features are available #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/compile-time-version-detect
branch
5 times, most recently
from
3e57037 to
274a853
Compare
randombit
force-pushed
the
jack/compile-time-version-detect
branch
8 times, most recently
from
c373863 to
46e9412
Compare
Previously features were gated on the botan3 feature (which is removed here). This didn't work well in practice as it made it difficult to add support for features added in Botan3 after the 3.0 release. Add declarations in botan-sys for functions added to ffi.h since 3.0.0, gated on the detected library version. Also add interfaces for some of the new functionality to the high level Rust crate.
randombit
force-pushed
the
jack/compile-time-version-detect
branch
from
46e9412 to
af5b75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously features were gated on the botan3 feature (which is removed here). This didn't work well in practice as it made it difficult to add support for features added in Botan3 after the 3.0 release.
Add declarations in botan-sys for functions added to ffi.h since 3.0.0, gated on the detected library version. Also add interfaces for some of the new functionality to the high level Rust crate.