Change kp refresh function name and pin redis version #456
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhbrar
reviewed
Aug 5, 2024
| @@ -186,7 +186,7 @@ async def catch_exceptions_middleware(request: Request, call_next): | |||
|
|
|||
|
|
|||
| @APP.on_event("startup") | |||
| async def get_kp_registry(): | |||
| async def refresh_kp_registry(): | |||
There was a problem hiding this comment.
If we change the name of this function, what are we calling now in line 682?
There was a problem hiding this comment.
We are now correctly calling line 48
There was a problem hiding this comment.
Ah okay, I missed that import. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The watchdog tests have been failing for a little while because the /kps endpoint was returning a 500. This fixes that.