-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mcq urls #459
Mcq urls #459
Conversation
mcq_answer_coalescer: AnyUrl = "https://answercoalesce.renci.org/query" | ||
mcq_genetics: AnyUrl = ( | ||
"https://translator.broadinstitute.org/genetics_provider/trapi/v1.5/query" | ||
) | ||
mcq_cohd: AnyUrl = "https://cohd.io/api/query" | ||
mcq_semsemian: AnyUrl = "http://mcq-trapi.monarchinitiative.org/1.5/query" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this via the smartapi metadata instead? It looks like the KPs have multicuriequery: true
in the x-trapi
block of their smartapi listings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is news to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semsemian isn't even registered on SmartAPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The decision was made on architecture that any service that provides MCQ should have that labelled. It looks like genetics and COHD at least do, while the other two don't. We should encourage them to do as such, since hard coding URLs isn't the greatest solution. But, if it's all we have for now, then there's nothing we can do about it.
No description provided.