Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcq urls #459

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Mcq urls #459

merged 3 commits into from
Aug 21, 2024

Conversation

maximusunc
Copy link
Collaborator

No description provided.

@maximusunc maximusunc requested a review from uhbrar August 21, 2024 18:02
Comment on lines +31 to +36
mcq_answer_coalescer: AnyUrl = "https://answercoalesce.renci.org/query"
mcq_genetics: AnyUrl = (
"https://translator.broadinstitute.org/genetics_provider/trapi/v1.5/query"
)
mcq_cohd: AnyUrl = "https://cohd.io/api/query"
mcq_semsemian: AnyUrl = "http://mcq-trapi.monarchinitiative.org/1.5/query"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this via the smartapi metadata instead? It looks like the KPs have multicuriequery: true in the x-trapi block of their smartapi listings.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is news to me

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is not standard.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semsemian isn't even registered on SmartAPI

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The decision was made on architecture that any service that provides MCQ should have that labelled. It looks like genetics and COHD at least do, while the other two don't. We should encourage them to do as such, since hard coding URLs isn't the greatest solution. But, if it's all we have for now, then there's nothing we can do about it.

@uhbrar uhbrar self-requested a review August 21, 2024 18:22
@maximusunc maximusunc merged commit 4fda116 into master Aug 21, 2024
4 checks passed
@maximusunc maximusunc deleted the mcq_urls branch August 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants