Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New options to java_signed_applet #2860

Closed
wants to merge 4 commits into from
Closed

New options to java_signed_applet #2860

wants to merge 4 commits into from

Conversation

shoxxdj
Copy link

@shoxxdj shoxxdj commented Jan 10, 2014

I hope this time indent is good .. if not tell me what i will change :)

@wchen-r7
Copy link
Contributor

Thanks for the PR. But yeah, you actually need to change back the following:

  • You should keep the "This module requires Metasploit..." header, that's what we currently use. You're actually using the old one.
  • You should keep the original 2-space tabs, because we don't use hard tabs anymore.

So the only thing you need to change is the new options.

@jvazquez-r7
Copy link
Contributor

You're still using hard-tabs, please don't change the original 2-space tabs. thanks!

@shoxxdj
Copy link
Author

shoxxdj commented Jan 14, 2014

i've replace all the hard tab to 2-space tabs. If it doesn't work i don't understant :/

@shoxxdj
Copy link
Author

shoxxdj commented Jan 19, 2014

Still have problem ?

@@ -138,7 +149,7 @@ def on_request_uri( cli, request )

jar.add_file("#{datastore["APPLETNAME"]}.class", @applet_class)

jar.build_manifest(:main_class => "metasploit.Payload")
jar.build_manifest(:main_class => datastore["Name"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will just break the payload.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ? It works on my computer ..

@shoxxdj
Copy link
Author

shoxxdj commented Jan 24, 2014

Sorrrrrrry ! First time in Ruby .. ^^

@shoxxdj
Copy link
Author

shoxxdj commented Feb 1, 2014

everything is good ?

@wchen-r7
Copy link
Contributor

@shoxxdj So our team had a discussion about this internally, and we decided to re-implement java_signed_applet. The final result is @jvazquez-r7's pull request #3043. We didn't really get to use your code because level of randomization, but you inspired us to improve it. Your PR will be closed here, but your effort is not wasted - We'll credit you in the upcoming blog for the weekly release update.

^ cc @todb-r7 about how we'd like to credit him since he's probably writing the next blog post.

@wchen-r7 wchen-r7 closed this Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants