-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New options to java_signed_applet #2860
Conversation
Thanks for the PR. But yeah, you actually need to change back the following:
So the only thing you need to change is the new options. |
Hope this time it's good ^^
You're still using hard-tabs, please don't change the original 2-space tabs. thanks! |
i've replace all the hard tab to 2-space tabs. If it doesn't work i don't understant :/ |
Still have problem ? |
@@ -138,7 +149,7 @@ def on_request_uri( cli, request ) | |||
|
|||
jar.add_file("#{datastore["APPLETNAME"]}.class", @applet_class) | |||
|
|||
jar.build_manifest(:main_class => "metasploit.Payload") | |||
jar.build_manifest(:main_class => datastore["Name"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will just break the payload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ? It works on my computer ..
Sorrrrrrry ! First time in Ruby .. ^^ |
everything is good ? |
@shoxxdj So our team had a discussion about this internally, and we decided to re-implement java_signed_applet. The final result is @jvazquez-r7's pull request #3043. We didn't really get to use your code because level of randomization, but you inspired us to improve it. Your PR will be closed here, but your effort is not wasted - We'll credit you in the upcoming blog for the weekly release update. ^ cc @todb-r7 about how we'd like to credit him since he's probably writing the next blog post. |
I hope this time indent is good .. if not tell me what i will change :)