Send the engine-id when calling DiscoveryConnection#save #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did we already remove the patch from the extensions gem? also can't we close this PR since @rtaylor-r7 has #144 |
Yeah, in a different branch. I'll merge the removal down to the current extensions gem branch as well as master, once this PR gets merged. |
sgreen-r7
added a commit
that referenced
this pull request
Mar 24, 2015
Send the engine-id when calling DiscoveryConnection#save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the upcoming releases will add a discovery connection type that supports sending
engine-idas a parameter. This unblocks @rtaylor-r7 who got bit by a monkey patchedDiscoveryConnection#as_xmlmethod when he was adding different parameters from another new discovery connection type.cc: @rtaylor-r7 @gschneider-r7 @sgreen-r7