Extract Rex::MIME dependency #201
Conversation
| end | ||
|
|
||
| def to_s | ||
| self.header.to_s + "\r\n" + content_encoded + "\r\n" |
|
What do we actually use this MIME code for anyway? Is it really still the case that there is nothing out there that can provide this functionality beyond Rex or a derivative? |
The methods
Either of these are candidates for refactoring. I'm not sure that a straight forward replacement exists though. Note that I only spent an hour or so looking at it several months ago. |
|
Gavin and I looked at it for a bit, and extracting that class is the quick fix, which could be completed in one PR. Doing it this way let's us get rid of Rex in the meantime and move forward on our own schedule for the refactoring of the extracted class. The refactor is not hard, but would need a bit of testing to make sure we didn't break anything. |
👍 |
|
So far the best I've found for The big trade-off right now is whether we have 1-2 external dependencies or 0 external dependencies. |
Removes Rex as a dependency from nexpose-client altogether. The Rex::MIME module has been incorporated into nexpose-client under the Rexlite::MIME module to avoid namespace collisions. At this time Rex::MIME was the only part of Rex that nexpose-client depended on. A few methods of Rex::Text were also pulled into the consuming classes in Rexlite::MIME.
Sicne it has used Rex::MIME in place of rest-client for a while the docs should be updated to reflect that.
gschneider-r7
force-pushed
the
rex_lite_mime
branch
from
13ba82d to
cb4cd1f
Compare
Extract Rex::MIME dependency
Removes Rex as a dependency from nexpose-client altogether. The Rex::MIME module has been incorporated into nexpose-client under the Rexlite::MIME module to avoid namespace collisions.
At this time Rex::MIME was the only part of Rex that nexpose-client depended on. A few methods of Rex::Text were also pulled into the consuming classes in Rexlite::MIME.
Rex::MIME::Message was used by the
Connection#import_scanandAdhocReportConfig#generatemethods.cc @sgreen-r7 @hdm @jhart-r7
All of the files pulled over are under the BSD 3-clause license in the Rex project I believe.