Use the #id reader instead of the nil @id variable #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -423,7 +423,7 @@ def self.copy(nsc, id) | |||
| # @param [Connection] nsc API connection to a Nexpose console. | |||
| # | |||
| def delete(nsc) | |||
| nsc.delete_scan_template(@id) | |||
There was a problem hiding this comment.
@mdaines-r7 Should ScanTemplate set @id? ScanTemplateSummary does. The use case is different since we read/write to the XML every time for the id of the full scan template class though.
There was a problem hiding this comment.
No, your fix is what it should do. Surprised this wasn't noticed earlier, but guess people were using the other method.
|
@mdaines-r7 @AdamBunn Can we push a gem release for #89 and this PR? |
|
You're correct. That is the issue here. |
mdaines-r7
added a commit
that referenced
this pull request
Nov 5, 2014
…e-delete Use the #id reader instead of the nil @id variable
|
@mdaines-r7 Awesome thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When template ID argument finally made it to url encoding when
String#gsubwas called on@idthe variable would be nil. This change uses the id getter method instead of the absent@idinstance variable (ScanTemplatenever sets it whileScanTemplateSummarydoes).