Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter to checkout success #60

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Dec 14, 2023

Because it doesn't really make sense to have a checkbox for the guest checkout (you can't un-subscribe as a guest with a graphql query), so I've replaced the guest checkout version with the textbox+register button that you'd normally find in the footer.

@royduin
Copy link
Member

royduin commented Dec 20, 2023

mutation-button-text? input-mutation? Maybe refactor a bit with clearer names?

jordythevulder
jordythevulder previously approved these changes Jan 29, 2024
@Jade-GG Jade-GG dismissed stale reviews from Roene-JustBetter and jordythevulder via eaaad56 March 8, 2024 11:51
@royduin royduin merged commit 251d771 into rapidez:master Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants