-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to load graphs server-side using custom functions #8
Merged
rlratzel
merged 11 commits into
rapidsai:branch-22.06
from
rlratzel:branch-22.06-updates_for_dgl_1
May 22, 2022
Merged
Add ability to load graphs server-side using custom functions #8
rlratzel
merged 11 commits into
rapidsai:branch-22.06
from
rlratzel:branch-22.06-updates_for_dgl_1
May 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion extensions functions to Thrift and client API.
rlratzel
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
python
labels
May 16, 2022
…xtension dir at startup.
…d tests to use that to determine if the server was ready, updated tests to cover preloaded extensions from the server CLI.
… end-to-end test and not just a unit test for the client API, made changes to allow tests to run without setting PYTHONPATH.
…owing thriftpy2.transport.TTransportError to be raised so users do not need to import thriftpy2 to catch exceptions from GaaS.
…with a default of 90 seconds.
alexbarghi-nv
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and tests for allowing clients to load graphs on the GaaS server using custom functions. This allows a complex graph creation process to be used in order to create the graph a server would manage.
closes #4