Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Transforms on cucim.clara use a fixed probability for the images in a batch #225

Closed
gigony opened this issue Feb 22, 2022 · 2 comments
Closed

[BUG] Transforms on cucim.clara use a fixed probability for the images in a batch #225

gigony opened this issue Feb 22, 2022 · 2 comments
Assignees
@shekhardw
Labels
improvement Improves an existing functionality MONAI MONAI-specific requests
Milestone
v22.02.01

Comments

@gigony
Copy link
Contributor

gigony commented Feb 22, 2022

Describe the bug
Transforms introduced by https://github.com/rapidsai/cucim/wiki/release_notes_v21.10.00#1-add-high-performance-transforms-for-digital-pathology-100 use a fixed probability for the images in a batch.

Steps/Code to reproduce bug

Use this tutorial.

https://github.com/Project-MONAI/tutorials/tree/master/pathology/tumor_detection

Additional context

Using fixed probability reduced the accuracy of the results.
@gigony gigony added the bug Something isn't working label Feb 22, 2022
@gigony gigony added this to the v22.02.01 milestone Feb 22, 2022
@shekhardw shekhardw added improvement Improves an existing functionality and removed bug Something isn't working labels Mar 1, 2022
@shekhardw shekhardw mentioned this issue Mar 2, 2022
Merged
@gigony gigony added the MONAI MONAI-specific requests label Mar 8, 2022
rapids-bot bot pushed a commit that referenced this issue Mar 31, 2022
@shekhardw
randomization per image per batch (#231)
7602774 
As per #225

Randomness updated to be applied to per image in the batch. Existing functionality of applying randomness on entire batch at once is unchanged.

Authors:
  - https://github.com/shekhardw

Approvers:
  - Gigon Bae (https://github.com/gigony)
  - https://github.com/jakirkham

URL: #231
@jakirkham
Copy link
Member

With PR ( #231 ) in, are we good to close or is there more needed here?

cc @shekhardw (for vis)

@gigony
Copy link
Contributor Author

gigony commented Apr 5, 2022

I think it's good to close this. Closing.

The remaining issue can be followed up by

@gigony gigony closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekhardw shekhardw

Labels
improvement Improves an existing functionality MONAI MONAI-specific requests
Projects
None yet
Milestone
v22.02.01
Development

No branches or pull requests
3 participants
@gigony @jakirkham @shekhardw