Add cucim.kit.cumed plugin with skeleton #129
Conversation
gigony
added
improvement
| ImageFormat() = default; | ||
| ~ImageFormat() = default; | ||
|
|
||
| bool add_interfaces(cucim::io::format::IImageFormat* image_formats); |
There was a problem hiding this comment.
Is it possible to use a reference here? Could the variable be const?
There was a problem hiding this comment.
Thanks for pointing it out!
Updated to use const variable.
|
|
||
| // Dynamically allocate memory for json_data (need to be freed manually); | ||
| const std::string& json_str = std::string{}; | ||
| char* json_data_ptr = static_cast<char*>(cucim_malloc(json_str.size() + 1)); |
There was a problem hiding this comment.
Is there a corresponding free somewhere? Would it be possible to use RAII to handle this allocation?
There was a problem hiding this comment.
Yes, it is at the destructor of CuImage class.
Lines 236 to 241 in 95e4483
I have created an issue to handle general resource handling issues and will follow up on the improvement through the issue.
|
|
||
| TEST_CASE("Verify file", "[test_basic.cpp]") | ||
| { | ||
| REQUIRE(1 == 1); |
There was a problem hiding this comment.
Were we wanting to add more here?
There was a problem hiding this comment.
Currently, it is just a placeholder to implement unit tests for cumed plugin.
gigony
force-pushed
the
add_cumed_plugin
branch
from
a904218 to
4f88f14
Compare
gigony
force-pushed
the
add_cumed_plugin
branch
from
4f88f14 to
230e1aa
Compare
|
@ajschmidt8 It seems that it has an issue with cuda11.5 (same for #128) 19:01:04 ++ python -c 'import cucim'
19:01:05 ci/gpu/build.sh: line 91: 1680 Segmentation fault (core dumped) python -c 'import cucim'
19:01:05 Build step 'Execute shell' marked build as failure
19:01:08 Recording test resultsIs there a known issue regarding this? Update: It seems so. I can see failures in other projects - rapidsai/cudf#9562 |
Yes, |
|
Thanks @ajschmidt8 for the confirmation! |
|
@gpucibot merge |
This change adds a skeleton plugin named
cucim.kit.cumedfor medical-related file loaders and image operations (e.g., .mhd file format support).The image loader to use is determined by
is_valid()method implemented in each plugin and CuImage object holds the reference to the image format descriptor (cucim::io::format::ImageFormatDesc*).cuCIM treats
cucim.kit.cuslideandcucim.kit.cumedplugins as built-in plugins, and it would support custom plugins in the future (by refactoring the framework code, according to the recent update of Carbonite (minimal) SDK library and use the library as it is).