Build with NumPy 1.17 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of letting `host`'s `numpy` have a minimum, which could float to a high version that is in turn pinned to a high version in `run`, build using the minimum required `numpy` version. That way the minimum is set similarly in `host` and a wide range of `numpy`'s will still work at runtime.
jakirkham
added
bug
|
In particular this caused some issues when installing |
raydouglass
approved these changes
Nov 16, 2021
Seems to be overly strict from a solver perspective.
|
rerun tests (one of the jobs failed, but it looks unrelated) |
|
rerun tests (pending job was likely lost during rename) |
|
@gpucibot merge |
|
rerun tests |
|
Debugging in PR ( #153 ) |
|
the segfault failure in this PR is unrelated to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of letting
host'snumpyhave a minimum, which could float to a high version that is in turn pinned to a high version inrun, build using the minimum requirednumpyversion. That way the minimum is set similarly inhostand a wide range ofnumpy's will still work at runtime.cc @quasiben (for awareness)