-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation with CuPy 10 #197
Conversation
okay, I guess |
conda/environments/env.yml
Outdated
@@ -2,7 +2,7 @@ name: cucim | |||
channels: | |||
- conda-forge | |||
dependencies: | |||
- cupy=9 | |||
- cupy>=9,<11.0.0a0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should just drop this constraint? I think the original motivation was to ensure we got CuPy 9 as we needed the very latest features. Do things work without a constraint here?
Edit: Alternatively we could just keep the lower bound. Since the goal of this is for use in development, we may need to use versions that have not yet been confirmed to work with cuCIM or the rest of RAPIDS. So having some flexibility helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with just keeping the lower bound. I think it should tend to find 10.0 without the constraint, but it doesn't hurt to indicate that it is incompatible with 8.x.
@gpucibot merge |
Now that CuPy 10.0 is out, we should also allow cuCIM to be installed with CuPy 10.x in the next release.
I checked the integration repo and it has the same constraint proposed here