Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation with CuPy 10 #197

Merged
merged 4 commits into from
Jan 19, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jan 19, 2022

Now that CuPy 10.0 is out, we should also allow cuCIM to be installed with CuPy 10.x in the next release.

I checked the integration repo and it has the same constraint proposed here

@grlee77 grlee77 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 19, 2022
@grlee77 grlee77 requested a review from a team as a code owner January 19, 2022 18:00
@grlee77
Copy link
Contributor Author

grlee77 commented Jan 19, 2022

okay, I guess /conda/recipes/cucim/meta.yaml had already been updated in #195, so this is now just an update of conda/environments/env.yml

@@ -2,7 +2,7 @@ name: cucim
channels:
- conda-forge
dependencies:
- cupy=9
- cupy>=9,<11.0.0a0
Copy link
Member

@jakirkham jakirkham Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should just drop this constraint? I think the original motivation was to ensure we got CuPy 9 as we needed the very latest features. Do things work without a constraint here?

Edit: Alternatively we could just keep the lower bound. Since the goal of this is for use in development, we may need to use versions that have not yet been confirmed to work with cuCIM or the rest of RAPIDS. So having some flexibility helps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with just keeping the lower bound. I think it should tend to find 10.0 without the constraint, but it doesn't hurt to indicate that it is incompatible with 8.x.

conda/environments/env.yml Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 47a4833 into rapidsai:branch-22.02 Jan 19, 2022
@gigony gigony added this to the v22.02.00 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants