Remove unused dependencies in GPU tests job #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Jacobelli <[email protected]>
jjacobelli
added
improvement
ajschmidt8
reviewed
Apr 25, 2022
| @@ -28,6 +28,7 @@ cd $WORKSPACE | |||
| export GIT_DESCRIBE_TAG=`git describe --abbrev=0 --tags` | |||
| export MINOR_VERSION=`echo $GIT_DESCRIBE_TAG | grep -o -E '([0-9]+\.[0-9]+)'` | |||
| echo "MINOR_VERSION: ${MINOR_VERSION}" | |||
| unset GIT_DESCRIBE_TAG | |||
There was a problem hiding this comment.
Can you elaborate on this change? GIT_DESCRIBE_TAB is set a few lines above.
There was a problem hiding this comment.
The GIT_DESCRIBE_TAG is defined by conda during build: https://docs.conda.io/projects/conda-build/en/latest/user-guide/environment-variables.html#git-environment-variables
Letting this variable defined in the environment before calling conda build can lead to some versions issues while building. To unify the script across all the RAPIDS CI scripts, I also added it here, despite it's not creating issues for this conda build. I will send you a slack thread with more details about this in private.
ajschmidt8
approved these changes
May 3, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some unused dependencies to reduce CI time