Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pypi CHANGELOG.md for releases 22.08.00 and 22.08.01 #404

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Sep 2, 2022

No description provided.

@grlee77 grlee77 added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change labels Sep 2, 2022
@grlee77 grlee77 requested a review from a team as a code owner September 2, 2022 10:44
@jakirkham
Copy link
Member

Think this got resolved by the forward-merge PR ( #403 ), but please double check

@grlee77
Copy link
Contributor Author

grlee77 commented Sep 3, 2022

That content is mostly the same, but this is a second copy of the CHANGELOG.md that is under the python/cucim folder and gets included in the long_description in setup.py so that it shows up on PyPI. I didn't realize we even had this second changelog when I did the 22.08.00 release, so it was not updated at that time. That is why both 22.08.00 and 22.08.01 changes are both here.

It seems we could migrate to just a single file going forward. (as for the README issue you recently raised in #397)

@grlee77
Copy link
Contributor Author

grlee77 commented Sep 3, 2022

This is where these second copies are used:

long_description='%s\n%s' % (
read('README.md'),
read('CHANGELOG.md')
),
long_description_content_type='text/markdown',

@jakirkham
Copy link
Member

jakirkham commented Sep 3, 2022

Oh missed that. Thanks for clarifying Greg 🙏

Yeah think tracking these duplicates down and coming up with a way to consolidate should save us additional maintenance work in the future

Edit: Tracking in issue ( #397 )

@jakirkham jakirkham added this to the v22.10.00 milestone Oct 4, 2022
@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ea83968 into rapidsai:branch-22.10 Oct 4, 2022
@jakirkham
Copy link
Member

Thanks Greg! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants