CuPy 14.0 compatibility #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication with scalar 1000. For cupy 14.0 this dtype conversion does not happen and overflow occurs instead, so we need to declare as int16 to start with
…alg.solve (behaves like in NumPy 2.0)
grlee77
added
bug
|
/merge |
|
Thanks Greg and Gigon! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming CuPy 14.0 release has some breaking change in dtype handling, etc. due to changes made to mirror NumPy 2.0 behavior.
Fortunately most of cuCIM was still working as is when I tested it locally. The changes made here are what was required for all tests to pass when using the current
mainbranch of CuPy (14.0 is not yet released)