Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Acquire spill lock in to/from_arrow (#13646)
Currently, calling `to_arrow` will render a cuDF Series/DataFrame unspillable. I believe it's just an oversight that we don't call to/from_arrow in an `acquire_spill_lock` context. Neither of those methods should expose the device pointer to a cuDF object externally. cc: @madsbk @vyasr -- could you take a look please? ```python In [1]: import cudf In [2]: s = cudf.Series([1, 2, 3]) In [3]: cudf.core.buffer.spill_manager.get_global_manager() Out[3]: <SpillManager spill_on_demand=True device_memory_limit=N/A | 0B spilled | 24B (0%) unspilled (unspillable)> In [4]: s.to_arrow() Out[4]: <pyarrow.lib.Int64Array object at 0x7f31e8f7ba60> [ 1, 2, 3 ] In [5]: cudf.core.buffer.spill_manager.get_global_manager() Out[5]: <SpillManager spill_on_demand=True device_memory_limit=N/A | 0B spilled | 24B (100%) unspilled (unspillable)> ``` Authors: - Ashwin Srinath (https://github.com/shwina) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Mads R. B. Kristensen (https://github.com/madsbk) - Peter Andreas Entschev (https://github.com/pentschev) URL: #13646
- Loading branch information