Skip to content

Commit

Permalink
Remove import preference
Browse files Browse the repository at this point in the history
  • Loading branch information
vyasr committed Aug 19, 2024
1 parent 1bd604a commit a3574b0
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions docs/cudf/source/developer_guide/pylibcudf.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ To satisfy the goals of pylibcudf, we impose the following set of design princip
- Every variable used should be strongly typed and either be a primitive type (int, float, etc) or a cdef class. Any enums in C++ should be mirrored using `cpdef enum`, which will create both a C-style enum in Cython and a PEP 435-style Python enum that will automatically be used in Python.
- All typing in code should be written using Cython syntax, not PEP 484 Python typing syntax. Not only does this ensure compatibility with Cython < 3, but even with Cython 3 PEP 484 support remains incomplete as of this writing.
- All cudf code should interact only with pylibcudf, never with libcudf directly.
- All imports should be relative so that pylibcudf can be easily extracted from cudf later
- Exception: All imports of libcudf API bindings in `cudf._lib.pylibcudf.libcudf` should use absolute imports of `cudf._lib.pylibcudf.libcudf as libcudf`. This will make it easier to extract
pylibcudf into a separate package.
- Ideally, pylibcudf should depend on nothing other than rmm and pyarrow. This will allow it to be extracted into a a largely standalone library and used in environments where the larger dependency tree of cudf may be cumbersome.
- Ideally, pylibcudf should depend on nothing other than rmm. This will allow it to be extracted into a a largely standalone library and used in environments where the larger dependency tree of cudf may be cumbersome.


## Relationship to libcudf
Expand Down

0 comments on commit a3574b0

Please sign in to comment.