Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNI for set operations #11143

Merged
merged 291 commits into from
Jul 28, 2022
Merged

Add JNI for set operations #11143

merged 291 commits into from
Jul 28, 2022

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jun 23, 2022

This PR add Java binding for the set-like operations:

  • lists::have_overlap
  • lists::intersect_distinct
  • lists::union_distinct
  • lists::difference_distinct

Depends on:

New Java APIs start here: https://github.com/rapidsai/cudf/pull/11143/files#diff-50ba2711690aca8e4f28d7b491373a4dd76443127c8b452a77b6c1fe2388d9e3R3545

@ttnghia ttnghia removed the 2 - In Progress Currently a work in progress label Jul 5, 2022
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the java API changes it looks great.

@ttnghia ttnghia added the 0 - Blocked Cannot progress due to external reasons label Jul 11, 2022
# Conflicts:
#	cpp/benchmarks/join/join_common.hpp
#	cpp/include/cudf/detail/search.hpp
#	cpp/include/cudf/detail/stream_compaction.hpp
#	cpp/include/cudf/lists/detail/set_operations.hpp
#	cpp/include/cudf/lists/set_operations.hpp
#	cpp/include/cudf/lists/stream_compaction.hpp
#	cpp/include/doxygen_groups.h
#	cpp/src/join/semi_join.cu
#	cpp/src/lists/set_operations.cu
#	cpp/src/lists/stream_compaction/distinct.cu
#	cpp/src/lists/utilities.cu
#	cpp/src/lists/utilities.hpp
#	cpp/src/search/contains_table.cu
#	cpp/src/stream_compaction/stable_distinct.cu
#	cpp/tests/CMakeLists.txt
#	cpp/tests/lists/stream_compaction/distinct_tests.cpp
#	java/src/main/native/src/ColumnViewJni.cu
#	java/src/main/native/src/ColumnViewJni.hpp
@github-actions github-actions bot removed the conda label Jul 26, 2022
@github-actions github-actions bot removed CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jul 26, 2022
@ttnghia ttnghia removed 0 - Blocked Cannot progress due to external reasons 5 - Merge After Dependencies labels Jul 26, 2022
@ttnghia ttnghia marked this pull request as ready for review July 27, 2022 03:18
@ttnghia ttnghia requested a review from a team as a code owner July 27, 2022 03:18
@ttnghia
Copy link
Contributor Author

ttnghia commented Jul 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ac51df1 into rapidsai:branch-22.08 Jul 28, 2022
@ttnghia ttnghia deleted the set_ops_jni branch July 28, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants