-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI for set operations #11143
Merged
Merged
Add JNI for set operations #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the java API changes it looks great.
# Conflicts: # cpp/benchmarks/join/join_common.hpp # cpp/include/cudf/detail/search.hpp # cpp/include/cudf/detail/stream_compaction.hpp # cpp/include/cudf/lists/detail/set_operations.hpp # cpp/include/cudf/lists/set_operations.hpp # cpp/include/cudf/lists/stream_compaction.hpp # cpp/include/doxygen_groups.h # cpp/src/join/semi_join.cu # cpp/src/lists/set_operations.cu # cpp/src/lists/stream_compaction/distinct.cu # cpp/src/lists/utilities.cu # cpp/src/lists/utilities.hpp # cpp/src/search/contains_table.cu # cpp/src/stream_compaction/stable_distinct.cu # cpp/tests/CMakeLists.txt # cpp/tests/lists/stream_compaction/distinct_tests.cpp # java/src/main/native/src/ColumnViewJni.cu # java/src/main/native/src/ColumnViewJni.hpp
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
New feature or request
Java
Affects Java cuDF API.
non-breaking
Non-breaking change
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add Java binding for the set-like operations:
lists::have_overlap
lists::intersect_distinct
lists::union_distinct
lists::difference_distinct
Depends on:
host_span<bitmask_type const*>
#11220New Java APIs start here: https://github.com/rapidsai/cudf/pull/11143/files#diff-50ba2711690aca8e4f28d7b491373a4dd76443127c8b452a77b6c1fe2388d9e3R3545