Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin dask and distributed for development #11859

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[REVIEW] Unpin dask and distributed for development #11859

merged 1 commit into from
Oct 5, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 4, 2022 •
edited
Loading

Description

This PR relaxes the pinnings of dask and distributed for 22.12 development.

Checklist

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 4, 2022
@galipremsagar galipremsagar self-assigned this Oct 4, 2022
@galipremsagar galipremsagar requested review from a team as code owners October 4, 2022 15:35
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Oct 4, 2022
This was referenced Oct 4, 2022
Merged
Merged
Merged
Merged
Merged
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Base: 87.40% // Head: 87.52% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (c53c3a2) compared to base (f72c4ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12   #11859      +/-   ##
================================================
+ Coverage         87.40%   87.52%   +0.11%     
================================================
  Files               133      133              
  Lines             21833    21807      -26     
================================================
+ Hits              19084    19086       +2     
+ Misses             2749     2721      -28
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
python/strings_udf/strings_udf/__init__.py 96.87% <100.00%> (ø)
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/cudf/cudf/core/column/numerical.py 95.21% <0.00%> (-0.29%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jolorunyomi
jolorunyomi approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@jolorunyomi jolorunyomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Oct 5, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6d18543 into rapidsai:branch-22.12 Oct 5, 2022
@jakirkham
Copy link
Member

@gpucibot merge

rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Oct 13, 2022
@galipremsagar
Unpin dask and distributed for development (#2772)
05421d1 
This PR relaxes the pinnings of `dask` and `distributed` for `22.12` development.


xref: rapidsai/cudf#11859

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Joseph (https://github.com/jolorunyomi)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2772
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Oct 14, 2022
@galipremsagar
Unpin dask and distributed for development (#886)
a44ea33 
This PR relaxes the pinnings of `dask` and `distributed` for `22.12` development.
xref: rapidsai/cudf#11859

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Joseph (https://github.com/jolorunyomi)

URL: #886
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Oct 14, 2022
@galipremsagar
Unpin dask and distributed for development (#4912)
522bed2 
This PR relaxes the pinnings of `dask` and `distributed` for `22.12` development.

xref: rapidsai/cudf#11859

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Joseph (https://github.com/jolorunyomi)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4912
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@galipremsagar
Unpin dask and distributed for development (rapidsai#4912)
c4654f5 
This PR relaxes the pinnings of `dask` and `distributed` for `22.12` development.

xref: rapidsai/cudf#11859

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Joseph (https://github.com/jolorunyomi)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolorunyomi jolorunyomi jolorunyomi approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @jakirkham @jolorunyomi