Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin dask and distributed for development #12302

Merged
merged 1 commit into from
Dec 12, 2022
Merged

[REVIEW] Unpin dask and distributed for development #12302

merged 1 commit into from
Dec 12, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

This PR unpins dask and distributed to 2022.12.0+ for 23.02 development.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 5, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner December 5, 2022 08:00
@galipremsagar galipremsagar self-assigned this Dec 5, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner December 5, 2022 08:00
@github-actions github-actions bot added ci Python Affects Python cuDF API. labels Dec 5, 2022
This was referenced Dec 5, 2022
Merged
Merged
Merged
Closed
Merged
@codecov
Copy link

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Base: 88.37% // Head: 88.18% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (ec8d9bf) compared to base (a9f9958).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head ec8d9bf differs from pull request most recent head 69025b4. Consider uploading reports for the commit 69025b4 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02   #12302      +/-   ##
================================================
- Coverage         88.37%   88.18%   -0.19%     
================================================
  Files               137      137              
  Lines             22657    22648       -9     
================================================
- Hits              20022    19972      -50     
- Misses             2635     2676      +41
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 93.66% <ø> (ø)
python/cudf/cudf/core/series.py 95.83% <ø> (ø)
python/dask_cudf/dask_cudf/core.py 73.90% <ø> (-0.31%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <ø> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <ø> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <ø> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <ø> (ø)
python/dask_cudf/dask_cudf/tests/test_core.py 95.42% <ø> (-0.02%) ⬇️
python/cudf/cudf/core/_base_index.py 81.15% <100.00%> (ø)
python/cudf/cudf/core/index.py 92.92% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Dec 5, 2022
This was referenced Dec 9, 2022
Merged
Closed
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Dec 12, 2022
@galipremsagar
Unpin dask and distributed for development (#1060)
3535cd3 
This PR unpins `dask` and `distributed` to `2022.12.0+` for `23.02` development.


xref: rapidsai/cudf#12302

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1060
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels Dec 12, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar changed the base branch from branch-23.02 to branch-22.12 December 12, 2022 19:08
@galipremsagar galipremsagar changed the base branch from branch-22.12 to branch-23.02 December 12, 2022 19:08
@rapids-bot rapids-bot bot merged commit b448ac2 into rapidsai:branch-23.02 Dec 12, 2022
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Dec 14, 2022
@galipremsagar
Unpin dask and distributed for development (#1068)
6d83c91 
This PR unpins `dask` and `distributed` to `2022.12.0+` for `23.02` development.

xref: rapidsai/cudf#12302

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1068
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 14, 2022
@galipremsagar
Unpin dask and distributed for development (#3036)
b5becc5 
This PR unpins `dask` and `distributed` to `2022.12.0+` for `23.02` development.

xref: rapidsai/cudf#12302

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3036
@galipremsagar galipremsagar mentioned this pull request Jan 3, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @raydouglass @charlesbluca