-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add move_to function to cudf::string_view iterator #13369
Closed
davidwendt
wants to merge
14
commits into
rapidsai:branch-23.08
from
davidwendt:string-iterator-move-to
Closed
Add move_to function to cudf::string_view iterator #13369
davidwendt
wants to merge
14
commits into
rapidsai:branch-23.08
from
davidwendt:string-iterator-move-to
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into string-iterator-move-to
…into string-iterator-move-to
Messed up moving this to 23.08 so closing this one and re-opening as #13428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - In Progress
Currently a work in progress
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
move_to()
function thecudf::string_view::const_iterator
class to help minimize character counting when creating and incrementing the iterator on multi-byte UTF8 characters.The function simply moves the iterator from the current character position to the given one. This is just a shortcut for the form
This pattern is repeated many times in #13322 and likely future PRs that require the same behavior.
The PR also includes an update to the
string_view::begin()
to set the byte-offset directly rather than waste instructions calculating it.Checklist