Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework libcudf regex benchmarks with nvbench #13464

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Rework libcudf regex benchmarks with nvbench #13464

merged 6 commits into from
Jun 5, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Reworks the libcudf regex benchmarks with nvbench to help measure varying column sizes and string widths as well as other parameters like hit-rate. Also, changed some existing nvbench implementations to standardize on the row_width and num_rows parameter names and order.
The function has changed. This better helps measure improvements as with changes in #13322

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2023
@davidwendt davidwendt self-assigned this May 26, 2023
@github-actions github-actions bot added the CMake CMake build issue label May 26, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 1, 2023
@davidwendt davidwendt marked this pull request as ready for review June 1, 2023 18:46
@davidwendt davidwendt requested a review from a team as a code owner June 1, 2023 18:46
karthikeyann
karthikeyann approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9092b56 into rapidsai:branch-23.08 Jun 5, 2023
@davidwendt davidwendt deleted the nvbench-regex branch June 5, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @bdice @karthikeyann