Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate strings_to_categorical in cudf.read_parquet #13540

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Deprecate strings_to_categorical in cudf.read_parquet #13540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a5a05
Deprecate strings_to_categorical
galipremsagar Jun 9, 2023
00cc45a
Merge branch 'branch-23.08' into strings_to_categorical
galipremsagar Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions python/cudf/cudf/io/parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,12 @@ def read_parquet(
):
"""{docstring}"""

if strings_to_categorical is not False:
warnings.warn(
"`strings_to_categorical` is deprecated and will be removed in "
"a future version of cudf.",
FutureWarning,
)
# Do not allow the user to set file-opening options
# when `use_python_file_object=False` is specified
if use_python_file_object is False:
Expand Down
10 changes: 7 additions & 3 deletions python/cudf/cudf/tests/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
TIMEDELTA_TYPES,
assert_eq,
assert_exceptions_equal,
expect_warning_if,
set_random_null_mask_inplace,
)

Expand Down Expand Up @@ -310,9 +311,12 @@ def test_parquet_reader_strings(tmpdir, strings_to_categorical, has_null):
assert os.path.exists(fname)

if strings_to_categorical is not None:
gdf = cudf.read_parquet(
fname, engine="cudf", strings_to_categorical=strings_to_categorical
)
with expect_warning_if(strings_to_categorical is not False):
gdf = cudf.read_parquet(
fname,
engine="cudf",
strings_to_categorical=strings_to_categorical,
)
else:
gdf = cudf.read_parquet(fname, engine="cudf")

Expand Down
5 changes: 5 additions & 0 deletions python/cudf/cudf/utils/ioutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,11 @@
strings_to_categorical : boolean, default False
If True, return string columns as GDF_CATEGORY dtype; if False, return a
as GDF_STRING dtype.

.. deprecated:: 23.08

This parameter is deprecated and will be removed in a future
version of cudf.
categorical_partitions : boolean, default True
Whether directory-partitioned columns should be interpreted as categorical
or raw dtypes.
Expand Down