Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KvikIO shared library #17239

Merged
merged 16 commits into from
Nov 7, 2024
Merged

KvikIO shared library #17239

merged 16 commits into from
Nov 7, 2024

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Nov 4, 2024 •
edited
Loading

Update cudf to use the new KvikIO shared library: rapidsai/kvikio#527

Tasks

@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 4, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Nov 4, 2024
madsbk
madsbk commented Nov 4, 2024
View reviewed changes
ci/build_wheel_libcudf.sh Outdated Show resolved Hide resolved
@madsbk madsbk mentioned this pull request Nov 4, 2024
Closed
3 tasks
@madsbk madsbk marked this pull request as ready for review November 4, 2024 15:39
@madsbk madsbk requested review from a team as code owners November 4, 2024 15:39
@madsbk madsbk added the DO NOT MERGE Hold off on merging; see PR for details label Nov 4, 2024
bdice
bdice reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment - I want to merge the upstream libkvikio shared library PR before final approval.

dependencies.yaml Outdated Show resolved Hide resolved
@madsbk madsbk mentioned this pull request Nov 6, 2024
Merged
@madsbk madsbk removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 6, 2024
@madsbk madsbk requested a review from a team as a code owner November 6, 2024 08:23
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 6, 2024
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Nov 6, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 6, 2024

This looks much better. Now we're just hitting the cuda-python issues.

vyasr
vyasr reviewed Nov 6, 2024
View reviewed changes
python/libcudf/CMakeLists.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CMake CMake build issue label Nov 6, 2024
@vyasr
Copy link
Contributor

vyasr commented Nov 7, 2024

/merge

@rapids-bot rapids-bot bot merged commit 57900de into rapidsai:branch-24.12 Nov 7, 2024
105 checks passed
@madsbk madsbk deleted the kvikio_shared_library branch November 9, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@jameslamb jameslamb jameslamb approved these changes

@vyasr vyasr vyasr approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@madsbk madsbk

@vyasr vyasr

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madsbk @vyasr @bdice @jameslamb