Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seed parameter to hash_character_ngrams #17643

Open
wants to merge 4 commits into
base: branch-25.02
Choose a base branch
from
Open

Add seed parameter to hash_character_ngrams #17643

wants to merge 4 commits into from

Conversation

davidwendt
Copy link
Contributor

Description

Adds a seed parameter to the nvtext::hash_character_ngrams API.
Makes this more useful in conjunction with other nvtext APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 20, 2024
@davidwendt davidwendt self-assigned this Dec 20, 2024
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 20, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jan 6, 2025
@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt
Copy link
Contributor Author

/ok to test

@davidwendt davidwendt marked this pull request as ready for review January 6, 2025 15:55
@davidwendt davidwendt requested a review from a team as a code owner January 6, 2025 15:55
@davidwendt davidwendt requested review from bdice and nvdbaranec January 6, 2025 15:55
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidwendt