Enable text build without relying on relaxed constexpr #17647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
PointKernel
added
feature request
|
/ok to test |
PointKernel
changed the title
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
lamarrr
approved these changes
Jan 6, 2025
bdice
approved these changes
Jan 6, 2025
| auto const [n, m] = std::minmax(str_length, tgt_length); | ||
| auto begin = str_length < tgt_length ? d_str.begin() : d_tgt.begin(); | ||
| auto itr = str_length < tgt_length ? d_tgt.begin() : d_str.begin(); | ||
| auto const n = cuda::std::min(str_length, tgt_length); |
There was a problem hiding this comment.
Can we open an issue requesting minmax in libcudacxx and link it here?
There was a problem hiding this comment.
NVIDIA/cccl#3243 done
There was a problem hiding this comment.
This could be cuda::std::minmax if one included <cuda/std/__algorithm/minmax.h>
( We are not done with porting all algorithms aka sorting algorithms are missing) and we do not feel comfortable officially exposing algorithm without it
davidwendt
approved these changes
Jan 6, 2025
1 task
|
/merge |
rapids-bot
bot
merged commit c4f2e8e
into
rapidsai:branch-25.02
106 of 107 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to #7795
This PR updates
textto build without depending on the relaxed constexpr build option.Checklist