Support multithreaded reading of compressed buffers in JSON reader #17670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FST (rapidsai#17471) Addresses rapidsai#15820 Authors: - Shruti Shivakumar (https://github.com/shrshi) Approvers: - Vukasin Milovanovic (https://github.com/vuule) - Nghia Truong (https://github.com/ttnghia) URL: rapidsai#17471
shrshi
added
feature request
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
…to json-multithreaded-compio
|
/ok to test |
|
/ok to test |
pmattione-nvidia
approved these changes
Jan 6, 2025
ttnghia
reviewed
Jan 7, 2025
Comment on lines
+119
to
+125
| std::future<size_t> device_read_async(size_t offset, | ||
| size_t size, | ||
| uint8_t* dst, | ||
| rmm::cuda_stream_view stream) override | ||
| { | ||
| auto& thread_pool = pools::tpool(); | ||
| return thread_pool.submit_task([this, offset, size, dst, stream] { |
There was a problem hiding this comment.
Will this be called by multiple threads? If so, we may have a race condition issue.
There was a problem hiding this comment.
No, device_read_async is only called by the primary thread. Each of the worker threads executes the code in thread_pool.submit_task(..)
ttnghia
reviewed
Jan 7, 2025
ttnghia
reviewed
Jan 7, 2025
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #17638
This PR introduces multithreaded host-side decompression of compressed input buffers passed to the JSON reader, and uses a stream pool to transfer the uncompressed buffers to device.
Checklist