Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting in logging #17680

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Fix formatting in logging #17680

merged 4 commits into from
Jan 6, 2025

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jan 4, 2025 •
edited
Loading

Description

Replace fmt-style {} syntax with printf-style %xyz format strings, because the fmt-style does not work with recent logger changes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 4, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 4, 2025
@vuule vuule added bug Something isn't working non-breaking Non-breaking change labels Jan 4, 2025
@vuule vuule marked this pull request as ready for review January 4, 2025 01:16
@vuule vuule requested a review from a team as a code owner January 4, 2025 01:16
@vuule vuule requested review from mythrocks and PointKernel January 4, 2025 01:16
@vuule
Copy link
Contributor Author

vuule commented Jan 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit 5d7686f into rapidsai:branch-25.02 Jan 6, 2025
105 of 106 checks passed
@vuule vuule deleted the bug-log-format branch January 6, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @ttnghia @PointKernel