Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove find_package(Python) in libcudf build #17683

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 6, 2025

Description

Nothing in libcudf's CMake should need a Python interpreter or linking to Python components. This proposes removing the find(Python) there, to simplify that build:

# Find Python early so that later commands can use it
find_package(Python 3.10 REQUIRED COMPONENTS Interpreter)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 6, 2025

This comment was marked as resolved.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue labels Jan 6, 2025
@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: remove find_package(Python) in libcudf build remove find_package(Python) in libcudf build Jan 6, 2025
@jameslamb jameslamb marked this pull request as ready for review January 6, 2025 16:22
@jameslamb jameslamb requested a review from a team as a code owner January 6, 2025 16:22
@bdice
Copy link
Contributor

bdice commented Jan 6, 2025

I wonder if we need to change our CMake codeowners. This didn't trigger for CMake code ownership, but probably should.

cpp/CMakeLists.txt @rapidsai/cudf-cmake-codeowners

should probably be just CMakeLists.txt rather than cpp/CMakeLists.txt.

If you agree, we can combine it into this PR or I can make a new one.

@jameslamb jameslamb requested a review from a team as a code owner January 6, 2025 17:01
@jameslamb
Copy link
Member Author

Yep I agree!

Pushed that change in 6b2ba0e

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 45a7329 into rapidsai:branch-25.02 Jan 6, 2025
109 checks passed
@jameslamb jameslamb deleted the simplify-libcuml-cmake branch January 6, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants