-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove find_package(Python) in libcudf build #17683
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-25.02
from
jameslamb:simplify-libcuml-cmake
Jan 6, 2025
Merged
remove find_package(Python) in libcudf build #17683
rapids-bot
merged 3 commits into
rapidsai:branch-25.02
from
jameslamb:simplify-libcuml-cmake
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Jan 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
/ok to test |
jameslamb
changed the title
WIP: remove find_package(Python) in libcudf build
remove find_package(Python) in libcudf build
Jan 6, 2025
bdice
approved these changes
Jan 6, 2025
I wonder if we need to change our CMake codeowners. This didn't trigger for CMake code ownership, but probably should. Line 11 in 955b1f4
should probably be just If you agree, we can combine it into this PR or I can make a new one. |
Yep I agree! Pushed that change in 6b2ba0e |
bdice
approved these changes
Jan 6, 2025
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
CMake build issue
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nothing in
libcudf
's CMake should need a Python interpreter or linking to Python components. This proposes removing thefind(Python)
there, to simplify that build:cudf/python/libcudf/CMakeLists.txt
Lines 37 to 38 in 955b1f4
Checklist